Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Nominatim OpenStreetMap search tool #5789

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

chazzhou
Copy link
Contributor

Description

This pull request introduces a new Nominatim OpenStreetMap search tool to Dify. The tool allows users to perform geocoding, reverse geocoding, and OSM object lookup using the Nominatim API. It supports both the public Nominatim service and self-hosted instances.

Key features:

  • Geocoding: Search for locations by address or place name
  • Reverse geocoding: Convert coordinates to addresses
  • OSM object lookup: Retrieve information about OSM objects by their IDs
  • Configurable base URL for self-hosted instances

This feature enhances Dify's capabilities in location-based applications.

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Tested geocoding with various addresses and place names
  • Tested reverse geocoding with different coordinate pairs
  • Tested OSM object lookup with node, way, and relation IDs

Screenshot from 2024-06-30 17-36-46

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 💪 enhancement New feature or request 🔨 feat:tools Tools for agent, function call related stuff. labels Jun 30, 2024
Copy link
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 1, 2024
@crazywoola crazywoola requested a review from laipz8200 July 1, 2024 00:44
@laipz8200 laipz8200 merged commit 850c227 into langgenius:main Jul 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request 🔨 feat:tools Tools for agent, function call related stuff. lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants