Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt] Removed "temp_off" from rule ID:BÁSICO_ELEMENTAR and ID:MUITO_BASTANTE_EXTENSIVAMENTE #10775

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

marcoagpinto
Copy link
Member

Heya, @susanaboatto and @p-goulart ,

I guess that maybe it is time to start removing “temp_off” from rules created weeks or months ago:
BÁSICO_ELEMENTAR
https://internal1.languagetool.org/regression-tests/via-http/2024-07-22/pt-BR_full/result_style_B%C3%81SICO_ELEMENTAR%5B1%5D.html

MUITO_BASTANTE_EXTENSIVAMENTE
https://internal1.languagetool.org/regression-tests/via-http/2024-07-22/pt-BR_full/result_style_MUITO_BASTANTE_EXTENSIVAMENTE%5B1%5D.html

😛 😛 😛 😛 😛 😛 😛 😛

@p-goulart
Copy link
Collaborator

@marcoagpinto: if you require a review and the PR is going stale, please ping us again. We don't have a habit of combing through week-old PRs every day. If something has been missed for more than a few days, it'll probably stay unreviewed unless you say something...

This is just removing temp_off on rules that have already been approved, I'd just go ahead and merge if I were you.

@marcoagpinto
Copy link
Member Author

@p-goulart

Thank you!

Also notice the pull request in the dictionaries opened two weeks ago.

Thanks!

@marcoagpinto marcoagpinto merged commit 8c445fe into master Aug 12, 2024
2 checks passed
@marcoagpinto marcoagpinto deleted the lt_marcoagpinto_20240723_0359 branch August 12, 2024 09:05
@p-goulart
Copy link
Collaborator

The dictionary PR will probably sit until the next monthly dictionary release. If the new entries are urgent, maybe make a hotfix in spelling.txt/added.txt instead?

@marcoagpinto
Copy link
Member Author

Ahhhhh... they aren't urgent since they are just a couple of compound words or so if I well remember.

😛 😛 😛 😛 😛

@p-goulart
Copy link
Collaborator

p-goulart commented Aug 12, 2024

Then I wouldn't worry too much. That repo is different because we don't release new binaries for every new word. The idea is very much to do it on a more or less monthly basis.

Just remember you can do both — add the words to spelling.txt/added.txt or whatever other hotfix plaintext files we have, and make an issue in the PT Dict repo. That way the words work immediately, and we'll make sure to include them in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants