[de] swiss german salutation rule #10805
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnaber
requested changes
Aug 2, 2024
| private final String id; | ||
|
|
||
| // Predefined category ids | ||
| public static final CategoryId PUNCTUATION = new CategoryId("PUNCTUATION"); |
There was a problem hiding this comment.
This already exists in class CategoryIds
| @@ -91,14 +94,17 @@ public List<Rule> getRelevantRemoteRules(ResourceBundle messageBundle, List<Remo | |||
|
|
|||
| @Override | |||
| public List<RuleMatch> filterRuleMatches(List<RuleMatch> ruleMatches, AnnotatedText text, Set<String> enabledRules) { | |||
| //First, use the filter in German.java | |||
| // First, use the filter in German.java | |||
There was a problem hiding this comment.
Please don't re-format the code in the same commit that makes the actual change
| @@ -0,0 +1,75 @@ | |||
| package org.languagetool.rules.de; | |||
There was a problem hiding this comment.
Please add the license header (see other .java files)
| + ")\\b,\\n" | ||
| ); | ||
|
|
||
| private static final Category PUNCTUATION_CATEGORY = new Category(CategoryId.PUNCTUATION, "Punctuation"); |
|
|
||
| public SwissGermanSalutationRule(ResourceBundle messages) { | ||
| super(messages); | ||
| setCategory(PUNCTUATION_CATEGORY); // Set the PUNCTUATION category |
There was a problem hiding this comment.
The comment isn't needed here, as the code shows what's happening
|
|
||
| private static final Category PUNCTUATION_CATEGORY = new Category(CategoryId.PUNCTUATION, "Punctuation"); | ||
|
|
||
| public SwissGermanSalutationRule(ResourceBundle messages) { |
There was a problem hiding this comment.
Could you add a test case for this class?
You can call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A rule that deletes the comma after salutation in Swiss German (as recommended) Is there a way to implement this as style (because the German variant is not super uncommon)?