Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.x] Added attempts() method to FakeJob #51951

Merged
merged 2 commits into from
Jun 28, 2024
Merged

[11.x] Added attempts() method to FakeJob #51951

merged 2 commits into from
Jun 28, 2024

Conversation

JamesFreeman
Copy link
Contributor

I'm currently getting this error when my job is trying to get the attempts method with the new withFakeQueueInteractions helper:

Error:

Error: Call to undefined method Illuminate\Queue\Jobs\FakeJob::attempts()
/Users/xxx/Sites/xxx/vendor/laravel/framework/src/Illuminate/Queue/InteractsWithQueue.php:32

See #51929 for further details

driesvints
driesvints approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@driesvints driesvints left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JamesFreeman. This lgtm.

@taylorotwell taylorotwell merged commit 85da360 into laravel:11.x Jun 28, 2024
28 checks passed
@JamesFreeman JamesFreeman deleted the bugfix/add-attempts-to-fake-job branch June 29, 2024 08:47
@blumilk-renovate blumilk-renovate bot mentioned this pull request Aug 1, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driesvints driesvints driesvints approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JamesFreeman @driesvints @taylorotwell