Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Run Workflows on Windows 2022 and with bash instead of powershell #51958

Merged
merged 4 commits into from
Jun 29, 2024

Conversation

Jubeki
Copy link
Contributor

@Jubeki Jubeki commented Jun 29, 2024

Replaces windows-2019 with windows-2022 next version will probably be windows-2025.

This also fixes a long standing issue, where the ^ symbol was being escaped in the windows command line / powershell.

Solution: explicitly use bash.

Copy link

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

@Jubeki Jubeki marked this pull request as ready for review June 29, 2024 13:43
@Jubeki Jubeki changed the title [11.x] Run Workflows on Windows 2022 [11.x] Run Workflows on Windows 2022 and with bash instead of powershell Jun 29, 2024
@taylorotwell taylorotwell merged commit 94df3d6 into laravel:11.x Jun 29, 2024
28 checks passed
@Jubeki Jubeki deleted the tests-windows branch June 29, 2024 13:50
@driesvints
Copy link
Member

Hah that's great @Jubeki. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants