Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Fix PHP_CLI_SERVER_WORKERS warning by suppressing it #52094

Merged

Conversation

pelomedusa
Copy link
Contributor

Context :

When using the PHP_CLI_SERVER_WORKERS environment variable with anything but 1, the command php artisan serve shows a warning with each HTTP request, sometimes multiple time depending on the value:

[Thu Jul 11 19:22:57 2024] Failed to poll event.

This PR remove this warning by applying the same fix as on 11.x (see #50821 )

Steps to reproduce :

  1. composer create-project laravel/laravel=10 testproject
  2. cd testproject
  3. PHP_CLI_SERVER_WORKERS=8 php artisan serve
  4. go to http://127.0.0.1:8000

Additional infos :

  • Before v10.40.0, the warning exists but does not show any message, just the date:
    [Thu Jul 11 19:01:20 2024]

  • The warning come from PHP itself but i did not go as far as compiling PHP myself to investigate further.

  • I assumed if the same fix was merged in 11.x, this PR was enough

This is my first PR on this repository, if you requires anything else please let me know.

@pelomedusa pelomedusa changed the title Fix PHP_CLI_SERVER_WORKERS warning by applying the same fix as 11.x [10.x] Fix PHP_CLI_SERVER_WORKERS warning by suppressing it Jul 11, 2024
@taylorotwell taylorotwell merged commit 96712ba into laravel:10.x Jul 11, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants