[11.x] Fix 'pushProcessor method not found on LoggerInterface' error

[cosmastech]

I came across this trying to unit test a package I'm working on where I want to use a logger spy. Though the only requirement stated is that the logger must be of Psr\Log\LoggerInterface, in practice, the log channel cannot be built.

Due to the change when adding the Context functionality, there's an implicit dependency that the LoggerInterface used by Logger must have a pushProcessor() method (provider by Monolog's ProcessableHandlerInterface).

The alternative approach is to add a method for Logger@pushProcessor().

todo:

• add unit tests

[github-actions]

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

[taylorotwell]

Can this be formatted differently? I can't really tell what is going on.

[cosmastech]

@taylorotwell hopefully this is easier to read. I find use of tap() inside of tap() to be very hard to read and to reason about, so I removed a tap statement.

For clarity, the goal is to only call Logger::pushProcessor() if the Logger::$logger instance has a method called pushProcessor.

As I was modifying this, another thought would be to allow Logger::withContext() to accept a Closure. Seems like a bigger, more error-prone lift.

The failing tests look like they're related to sqlite changes from earlier today.

[taylorotwell]

Thanks!