Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.x] Fix SQL Server tests #52222

Merged
merged 2 commits into from
Jul 22, 2024
Merged

[11.x] Fix SQL Server tests #52222

merged 2 commits into from
Jul 22, 2024

Conversation

hafezdivandari
Copy link
Contributor

Fix failing sqlsrv test.

@github-actions GitHub Actions
Copy link

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

@hafezdivandari
Copy link
Contributor Author

@driesvints I've fixed the failing sqlsrv tests as discussed here, but other failing tests are seems to be related to PR #52190.

@driesvints
Copy link
Member

Thanks @hafezdivandari. @timacdonald will check into the other test.

@driesvints driesvints marked this pull request as ready for review July 22, 2024 13:49
@taylorotwell taylorotwell merged commit 29a58fe into laravel:11.x Jul 22, 2024
17 of 29 checks passed
@hafezdivandari hafezdivandari deleted the 11.x-fix-tests branch July 22, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driesvints driesvints driesvints approved these changes

@taylorotwell taylorotwell Awaiting requested review from taylorotwell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hafezdivandari @driesvints @taylorotwell