[11.x] Fully qualify morph columns when using WHERE clauses

[maartenpaauw]

When using multiple tables with the same morph columns, the query could be ambitious. This pull request fix that by qualifying all morph columns.

[maartenpaauw]

I'm not sure why the testItCanTravelByMicroseconds test is failing. I think the changes I've made didn't affect any of that logic.

[driesvints]

Hi there. Please rebase this PR as we've fixed the test suite on the 11.x branch. Then mark your PR as ready again.

[maartenpaauw]

@driesvints alright! That you for the clarification. I've rebased this branch and all tests are passing.

[taylorotwell]

How do you have two tables with the exact same morph column names?

[maartenpaauw]

Thanks for merging this PR. I’m sorry for my delayed response. I couldn’t find any time earlier, but I still want to explain why this is needed.

What I meant by multiple tables having the same morph column names is the following situation.

Let’s assume we have a parent and a child model. Both models have a morph to a contact. Let’s also assume the parent and child models aren’t always morphed to the same contact. Therefore, both models have contactable_type and contactable_id columns.

If we want to scope the parent relationship and include the child relationships, we’ll get an overly ambitious MySQL error.

The same column qualification is used when calling the whereBelongsTo method.