[11.x] Fix SQLite schema dumps missing most tables #52275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @bakerkretzmar for your help. I'm closing my PR now as this one fixes my issue from my local testing of this change with my app. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug I introduced in #52172 that would cause SQLite schema dumps to be mostly empty. My original regular expression was too greedy and removed almost the entire file contents. This PR adds a test to cover this case and adds the
?modifier to make the relevant part of the regex lazy, so it will consume at most oneCREATE TABLEstatement at a time as intended. See regexr.com/83vo9 (includes global flag but that isn't necessary forpreg_replace).Closes #52254.