Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom site domains to valet php and valet composer #1274

Closed
wants to merge 3 commits into from

Commits on Aug 2, 2022

  1. Add support for custom site domains to valet php and valet composer

    Fixes laravel#1272
    
    Adds support for passing in a custom sitename via the flag `--site=sitename`
    - Could be more flexible, at this point the '=' is mandatory
    - Command help updated, arguments added etc
    - Code is repeated in two place, I thought it more likely that potential flags / checks diverge over time and didn't want to prematurely abstract
    
    Potential issues
    - someone calling a php command that requires a "--site" flag is not going to be able to pass it in.
    
    Other considerations
    - It would be better if the isolate function wasn't so tied to dir names - keeping a config file of isolated sites vs just parsing nginx configs seems better to me in the long run but is a larger and more serious refactor of valet.
    aj-adl committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    dae7fa3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6b3283a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9add588 View commit details
    Browse the repository at this point in the history