Fix renamer generating duplicate declarations in switch statements #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The entire switch statement is considered one scope, so we need to thread through the renamer environment so we don't generate duplicate definitions. It turns out the test case I added in laurentlb#132 already hit this -- the output was not valid GLSL -- but I didn't notice :(
laurentlb
approved these changes
May 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The entire switch statement is considered one scope, so we need to
thread through the renamer environment so we don't generate duplicate
definitions.
It turns out the test case I added in #132 already hit this -- the
output was not valid GLSL -- but I didn't notice :(