Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: include bare 'open Classical' in tech debt metrics #15490

Closed
wants to merge 3 commits into from

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Aug 4, 2024

And remove one commented counter: there is now a lint against deprecations without a date, so keeping it is probably not useful.


Open in Gitpod

@grunweg grunweg added the tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip label Aug 4, 2024
Copy link

github-actions bot commented Aug 4, 2024

PR summary 1fe8da9f0a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

Co-authored-by: damiano <[email protected]>
@adomani
Copy link
Collaborator

adomani commented Aug 5, 2024

Thanks a lot!

maintainer merge

Copy link

github-actions bot commented Aug 5, 2024

🚀 Pull request has been placed on the maintainer queue by adomani.

@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Aug 5, 2024
mathlib-bors bot pushed a commit that referenced this pull request Aug 5, 2024
And remove one commented counter: there is now a lint against deprecations without a date, so keeping it is probably not useful.
@bryangingechen
Copy link
Contributor

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Aug 6, 2024
And remove one commented counter: there is now a lint against deprecations without a date, so keeping it is probably not useful.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Aug 6, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: include bare 'open Classical' in tech debt metrics [Merged by Bors] - chore: include bare 'open Classical' in tech debt metrics Aug 6, 2024
@mathlib-bors mathlib-bors bot closed this Aug 6, 2024
@mathlib-bors mathlib-bors bot deleted the MR-tech-debt-openClassical branch August 6, 2024 05:49
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
And remove one commented counter: there is now a lint against deprecations without a date, so keeping it is probably not useful.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-merge ready-to-merge This PR has been sent to bors. tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants