-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore: include bare 'open Classical' in tech debt metrics #15490
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grunweg
added
the
tech debt
Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip
label
Aug 4, 2024
PR summary 1fe8da9f0aImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for |
adomani
reviewed
Aug 4, 2024
adomani
reviewed
Aug 4, 2024
Co-authored-by: damiano <[email protected]>
eric-wieser
reviewed
Aug 4, 2024
Co-authored-by: Eric Wieser <[email protected]>
Thanks a lot! maintainer merge |
🚀 Pull request has been placed on the maintainer queue by adomani. |
Thanks! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Aug 5, 2024
And remove one commented counter: there is now a lint against deprecations without a date, so keeping it is probably not useful.
bors r+ |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
And remove one commented counter: there is now a lint against deprecations without a date, so keeping it is probably not useful.
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
chore: include bare 'open Classical' in tech debt metrics
[Merged by Bors] - chore: include bare 'open Classical' in tech debt metrics
Aug 6, 2024
bjoernkjoshanssen
pushed a commit
that referenced
this pull request
Sep 9, 2024
And remove one commented counter: there is now a lint against deprecations without a date, so keeping it is probably not useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
maintainer-merge
ready-to-merge
This PR has been sent to bors.
tech debt
Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And remove one commented counter: there is now a lint against deprecations without a date, so keeping it is probably not useful.