Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(Subgroup/MulOpposite): add Normal instance #15497

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat(Subgroup/MulOpposite): add Normal instance #15497

wants to merge 6 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Aug 4, 2024 •
edited by Parcly-Taxel
Loading

  • add op_injective,op_inj,op_eq_bot,op_eq_top;
  • add op_normalizer, op_normal, Normal.op, Normal.of_op, op.instNormal;
  • similarly for unop.

Open in Gitpod

@urkud
feat(Subgroup/MulOpposite): add Normal.opposite
82560f9
@urkud
Merge master into YK-subgroup-opposite (using imerge)
58714a4
@urkud
feat(Subgroup/MulOpposite): add Normal instance
b8e60db 
- add `op_injective, `op_inj`, `op_eq_bot`, `op_eq_top`;
- add `op_normalizer`, `op_normal`, `Normal.op`, `Normal.of_op`, `op.instNormal`;
- similarly for `unop`.
@urkud urkud added the t-algebra Algebra (groups, rings, fields, etc) label Aug 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 4, 2024 •
edited
Loading

PR summary dd3de614e8

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ normal_op
+ normal_unop
+ op.instNormal
+ op_normalizer
+ unop.instNormal
+ unop_normalizer
+ ⟨Normal.of_op,
+ ⟨Normal.of_unop,
++++ op_eq_bot
++++ op_eq_top
++++ op_inj
++++ op_injective
++++ unop_eq_bot
++++ unop_eq_top
++++ unop_inj
++++ unop_injective
+-+-+-+- unop_inf
-+-+-+-+ op_inf
-+-+-+-+ op_top
-+-+-+-+ unop_top

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@urkud urkud requested a review from eric-wieser August 20, 2024 02:32
jcommelin
jcommelin reviewed Aug 27, 2024
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Aug 27, 2024
mathlib-bors bot pushed a commit that referenced this pull request Aug 27, 2024
@urkud
feat(Subgroup/MulOpposite): add Normal instance (#15497)
d237181 
- add `op_injective`,`op_inj`,`op_eq_bot`,`op_eq_top`;
- add `op_normalizer`, `op_normal`, `Normal.op`, `Normal.of_op`, `op.instNormal`;
- similarly for `unop`.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Aug 27, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Subgroup/MulOpposite): add Normal instance [Merged by Bors] - feat(Subgroup/MulOpposite): add Normal instance Aug 27, 2024
@mathlib-bors mathlib-bors bot closed this Aug 27, 2024
@mathlib-bors mathlib-bors bot deleted the YK-subgroup-opposite branch August 27, 2024 21:15
bjoernkjoshanssen pushed a commit that referenced this pull request Sep 9, 2024
@urkud @bjoernkjoshanssen
feat(Subgroup/MulOpposite): add Normal instance (#15497)
fb63c36 
- add `op_injective`,`op_inj`,`op_eq_bot`,`op_eq_top`;
- add `op_normalizer`, `op_normal`, `Normal.op`, `Normal.of_op`, `op.instNormal`;
- similarly for `unop`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

@eric-wieser eric-wieser Awaiting requested review from eric-wieser

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@urkud @eric-wieser @jcommelin @leanprover-community-mathlib4-bot