Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use builtin_initialize in library_search #3677

Merged
merged 2 commits into from
Mar 14, 2024
Merged

fix: use builtin_initialize in library_search #3677

merged 2 commits into from
Mar 14, 2024

Conversation

joehendrix
Copy link
Contributor

This replaces a few uses of initialize with builtin_initialize, and removes some unneeded functionality added when it was unclear if lazy discriminator trees would be efficient enough.

@joehendrix
chore: remove unused libsearch generality.
96ec0cf 
This was initially developed before we had confidence lazy discriminator
trees were performant.
@joehendrix
fix: use builtin_initialize
1fe505e
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc March 14, 2024 07:02 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Mar 14, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Std/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 995726f75fd7eed223c2189a54f6df3293185327 --onto 317adf42e92a4dbe07295bc1f0429b61bb8079fe. (2024-03-14 07:11:54)

@joehendrix joehendrix added this pull request to the merge queue Mar 14, 2024
Merged via the queue into master with commit 1151d73 Mar 14, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leodemoura leodemoura Awaiting requested review from leodemoura leodemoura is a code owner

Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joehendrix @leanprover-community-mathlib4-bot