Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: hovering over omission term shows reason for omission #3751

Merged
merged 3 commits into from
Mar 27, 2024
Merged

feat: hovering over omission term shows reason for omission #3751

merged 3 commits into from
Mar 27, 2024

Conversation

kmill
Copy link
Collaborator

@kmill kmill commented Mar 23, 2024 •
edited
Loading

This avoids printing the entire docstring for ⋯ when hovering over it, which is rather long, and instead it gives a brief reason for omission and what option to set to pretty print the omitted term.

@kmill kmill requested a review from mhuisi as a code owner March 23, 2024 09:34
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Mar 23, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Std/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 2ed777b2b4fb90856ce74ed8ec1460e650062946 --onto 6c8976abbea74e6abb059de6267a0804cf14f614. (2024-03-23 09:50:24)

mhuisi
mhuisi approved these changes Mar 25, 2024
View reviewed changes
src/Lean/PrettyPrinter/Delaborator/Basic.lean Outdated Show resolved Hide resolved
@kmill kmill added the awaiting-review Waiting for someone to review the PR label Mar 26, 2024
@mhuisi mhuisi added this pull request to the merge queue Mar 27, 2024
Merged via the queue into leanprover:master with commit 70924be Mar 27, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhuisi mhuisi mhuisi approved these changes

Assignees
No one assigned
Labels
awaiting-review Waiting for someone to review the PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kmill @leanprover-community-mathlib4-bot @mhuisi