fix: loose bound variables at ACLt #3819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #3705 test: for issue
nomeata
reviewed
Apr 1, 2024
| if ptrAddrUnsafe a == ptrAddrUnsafe b then | ||
| if a == b then | ||
| -- We used to have an "optimization" using only pointer equality. | ||
| -- This was a bad idea, `==` is often much cheaper than `acLt`. |
There was a problem hiding this comment.
A reader might think that the pointer equality optimization was a bad idea (and not the “only”)
Suggested change
| -- This was a bad idea, `==` is often much cheaper than `acLt`. | |
| -- This was insufficient, as `==` is often much cheaper than `acLt`. |
nomeata
reviewed
Apr 1, 2024
| @@ -84,6 +86,16 @@ where | |||
| else | |||
| lt a₂ b₂ | |||
|
|
|||
| getParamsInfo (f : Expr) (numArgs : Nat) : MetaM (Array ParamInfo) := do | |||
| -- Ensure `f` does not have loose bound variables. This may happen in | |||
There was a problem hiding this comment.
Suggested change
| -- Ensure `f` does not have loose bound variables. This may happen in | |
| -- Ensure `f` does not have loose bound variables. This may happen |
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3705
This PR also fixes a performance issue at
ACLtalso exposed by example at #3705