Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: omega works as a simp discharger #3828

Merged
merged 1 commit into from
Apr 3, 2024
Merged

fix: omega works as a simp discharger #3828

merged 1 commit into from
Apr 3, 2024

Conversation

semorrison
Copy link
Collaborator

Possibly the more principled fix is to not have simp invoke dischargers under withReducible.

In the meantime, this ensures that falseOrByContra still succeeds with intro1 on a Not goal, which previously was breaking omega as a simp discharger.

Closes #3805.

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc April 3, 2024 00:42 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Apr 3, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Mathlib CI can not be attempted yet, as the nightly-testing-2024-04-02 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Mathlib CI should run now. (2024-04-03 00:45:06)

@semorrison semorrison added this pull request to the merge queue Apr 3, 2024
Merged via the queue into master with commit f3121b0 Apr 3, 2024
11 checks passed
@semorrison semorrison deleted the fix_3805 branch April 3, 2024 06:52
@hwatheod hwatheod mentioned this pull request May 5, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't use omega as a simp discharger
2 participants
@semorrison @leanprover-community-mathlib4-bot