-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: whitespace and message ordering configurations for #guard_msgs
#3883
Conversation
The code action also needs to be modified to take the |
@digama0 It's now about ready to come out of draft state. If you approve, then I'll go and create a PR for the first commit (bc75d48), then update stage0, and then this PR will just be for the third commit. It turns out the code action didn't need special handling since the sorted version is passed into the info tree. I tested it by using it to create the docstrings in the test file. |
Implementation for this configuration syntax will appear after a stage0 update.
@digama0 The staging business is all worked out now in this PR, and it's set to trigger a stage0 update after it merges. |
Okay, LGTM. Let's see if merging works... |
Should this be considered a workaround for #2335? |
@Kha Yes, though it goes a little further since, for example, a tactic might spawn multiple threads and report multiple messages nondeterministically at the same source position. |
Adds options to control whitespace normalization and message ordering in
#guard_msgs
.Examples:
#guard_msgs (whitespace := lax)
ignores differences in whitespace completely.#guard_msgs (whitespace := exact)
requires an exact match for whitespace (after trimming).#guard_msgs (ordering := sorted)
sorts the list of messages, to make it insensitive to message order.