fix: add unused variables ignore function for #guard_msgs
#3931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `#guard_msgs` command already runs linters by virtue of using `elabCommandTopLevel`. Linters should *not* be run on `#guard_msgs` itself, however the unused variables linter is the noisiest one, and it's easy enough to make it not report messages for `#guard_msgs`.
semorrison
approved these changes
Apr 17, 2024
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
nomeata
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
#guard_msgscommand already runs linters by virtue of usingelabCommandTopLevel, so linters should not be run on#guard_msgsitself. While we could use a more general solution, of the linters the unused variables linter is the noisiest one, and it's easy enough to make it not report messages for#guard_msgs.