Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add dates to @[deprecated] attributes #3967

Merged
merged 3 commits into from
May 14, 2024
Merged

chore: add dates to @[deprecated] attributes #3967

merged 3 commits into from
May 14, 2024

Conversation

semorrison
Copy link
Collaborator

@semorrison semorrison commented Apr 22, 2024 •
edited
Loading

No description provided.

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc April 22, 2024 03:53 Inactive
@semorrison semorrison added this pull request to the merge queue Apr 22, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Apr 22, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Apr 22, 2024 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Std/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase ac0f699775a39fa6070135426c403fd5df204eda --onto 62cdb51ed5b9d8487877d5a4adbcd4659d81fc6a. (2024-04-22 03:56:25)
  • ✅ Mathlib branch lean-pr-testing-3967 has successfully built against this PR. (2024-05-14 04:42:41) View Log

@digama0 digama0 mentioned this pull request Apr 22, 2024
Merged
@semorrison semorrison removed this pull request from the merge queue due to a manual request Apr 22, 2024
@semorrison
Copy link
Collaborator Author

Waiting on #3968 now.

github-merge-queue bot pushed a commit that referenced this pull request Apr 23, 2024
@digama0
feat: improve @[deprecated] attr (#3968)
4f664fb 
Complement to #3967 , adds a `(since := "<date>")` field to
`@[deprecated]` so that metaprogramming code has access to the
deprecation date for e.g. bulk removals. Also adds `@[deprecated
"deprecation message"]` to optionally replace the default text
"`{declName}` has been deprecated, use `{newName}` instead".
@semorrison semorrison disabled auto-merge May 14, 2024 03:09
@semorrison semorrison enabled auto-merge May 14, 2024 03:09
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc May 14, 2024 03:23 Inactive
@semorrison semorrison added this pull request to the merge queue May 14, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 14, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#3967
14cc70c
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 14, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#3967
4229788
Merged via the queue into master with commit 91244b2 May 14, 2024
14 checks passed
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-christiansen david-christiansen Awaiting requested review from david-christiansen david-christiansen is a code owner

@Vtec234 Vtec234 Awaiting requested review from Vtec234 Vtec234 is a code owner

@leodemoura leodemoura Awaiting requested review from leodemoura leodemoura is a code owner

Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@semorrison @leanprover-community-mathlib4-bot