Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add seal and unseal commands #4053

Merged
merged 1 commit into from
May 3, 2024
Merged

feat: add seal and unseal commands #4053

merged 1 commit into from
May 3, 2024

Conversation

leodemoura
Copy link
Member

No description provided.

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc May 2, 2024 18:52 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label May 2, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Std/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 092ca8530a6f272b7cb19235750479cdffab11de --onto 806e41151b6eb645e4ed5a40915b94b99f933564. (2024-05-02 18:54:59)

@nomeata
Copy link
Contributor

nomeata commented May 2, 2024

Do we want/need the seal … in $c:command variant, and maybe also the seal … in variant for terms and tactics?

@leodemoura
Copy link
Member Author

Do we want/need the seal … in $c:command variant, and maybe also the seal … in variant for terms and tactics?

We already have it. See new test:

seal f in
example : f x = x + 1 := rfl

@nomeata
Copy link
Contributor

nomeata commented May 2, 2024

Ah, neat! I didn't expect that after scrolling through the macro definition. Neat.

@leodemoura leodemoura added this pull request to the merge queue May 3, 2024
Merged via the queue into master with commit e362b50 May 3, 2024
12 checks passed
nomeata pushed a commit that referenced this pull request May 3, 2024
@Kha
Copy link
Member

Kha commented May 3, 2024

@nomeata in is a generic command combinator

@nomeata
Copy link
Contributor

nomeata commented May 3, 2024

But I assume it won’t work scoped around terms and tactics for free, does it?
(Not urgently needed).

I’m a heavy user of unseal already:
leanprover-community/mathlib4@nightly-testing...lean-pr-testing-4061

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants