Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: code duplication at liftCoreM and liftTermElabM at Command.lean #4080

Merged
merged 1 commit into from
May 6, 2024
Merged

fix: code duplication at liftCoreM and liftTermElabM at Command.lean #4080

merged 1 commit into from
May 6, 2024

Conversation

leodemoura
Copy link
Member

This PR also fixes:

  • Fields caching specific Options at CoreM are now properly set.
  • nextMacroScope was not being propagated at liftCoreM.

@leodemoura
fix: code duplication at liftCoreM and liftTermElabM at `Command.…
c355269 
…lean`

This PR also
- Fields caching specific `Options` at `CoreM` are properly set.
- `nextMacroScope` was not being propagated at `liftCoreM`.
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc May 6, 2024 18:52 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label May 6, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Std/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 26a1b934c226c6aa923248804ba92c23f56c5115 --onto e362b50fa95d6823e59dd706803a93c25e888535. (2024-05-06 18:54:59)

@leodemoura leodemoura added this pull request to the merge queue May 6, 2024
@digama0
Copy link
Collaborator

digama0 commented May 6, 2024

Does this fix #3499 as well?

Merged via the queue into master with commit 00dceb9 May 6, 2024
12 checks passed
@leodemoura
Copy link
Member Author

Does this fix #3499 as well?

No.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leodemoura @leanprover-community-mathlib4-bot @digama0