Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lake: add readme to package templates #4147

Merged
merged 3 commits into from
May 18, 2024

Conversation

alok
Copy link
Contributor

@alok alok commented May 13, 2024

Messaged @tydeu about adding a README.md to new lake projects. I decided to add it with the help of GPT.

@tydeu
Copy link
Member

tydeu commented May 14, 2024

@alok Thanks! Looks good! There is a type error that needs fixing, though.

@tydeu tydeu changed the title Add empty readme in new lake projects feat: lake: add readme to package templates May 14, 2024
@tydeu tydeu added the awaiting-author Waiting for PR author to address issues label May 14, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label May 14, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 799923d145960c6f2515b510111df2c170b34ca3 --onto 91244b2dd9d223006227648659203373f5a46b0b. (2024-05-14 18:54:51)

src/lake/Lake/CLI/Init.lean Outdated Show resolved Hide resolved
@tydeu tydeu removed the awaiting-author Waiting for PR author to address issues label May 17, 2024
@tydeu
Copy link
Member

tydeu commented May 17, 2024

@alok Any reason why you still have this marked as draft?

@alok alok marked this pull request as ready for review May 17, 2024 06:35
@alok
Copy link
Contributor Author

alok commented May 17, 2024 via email

@tydeu tydeu added this pull request to the merge queue May 18, 2024
Merged via the queue into leanprover:master with commit 489d2d1 May 18, 2024
12 checks passed
@tydeu
Copy link
Member

tydeu commented May 18, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants