fix: hovers on binders with metavariables #4192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
May 16, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 16, 2024
|
The changes to the test output looks reasonable, in one case we see that the info tree no longer contains entries from a back-tracked attempt at elaboration. |
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
May 16, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 16, 2024
|
Mathlib CI status (docs):
|
|
Interesting, this makes the unused-variable-linter better (see leanprover-community/batteries#802) |
nomeata
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 16, 2024
leanprover-community-mathlib4-bot
added
the
builds-mathlib
kmill
approved these changes
May 19, 2024
I don't know. It might be good to double-check and document the need for this parameter but that shouldn't hold back this PR. |
Kha
approved these changes
May 21, 2024
|
IIRC the original intent was to retain information from overloading but it seems some (all?) of that was switched to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes #4078. It is an alternative fix to the one in #4137, suggested
by @kmill.
Incidentially, it makes the unused variable linter better. My theory is that
if we don’t reset the info when backtracking, the binder shows up more than
once in the info tree, and then it is considered “used”, although there are
just multiple binders.