Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing withIncRecDepth and unifyEqs? and add support for offsets at unifyEq? #4224

Merged
merged 2 commits into from
May 20, 2024
Merged

fix: missing withIncRecDepth and unifyEqs? and add support for offsets at unifyEq? #4224

merged 2 commits into from
May 20, 2024

Conversation

leodemoura
Copy link
Member

@leodemoura leodemoura commented May 20, 2024 •
edited
Loading

Given h with type x + k = y + k' (or h : k = k'), cases h produced a proof of size linear in min k k'. isDefEq has support for offset, but unifyEq? did not have it, and a stack overflow occurred while processing the resulting proof. This PR fixes this issue.

closes #4219

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc May 20, 2024 01:04 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label May 20, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 20, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4224
7c9af6e
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 20, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4224
965bd7e
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label May 20, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented May 20, 2024 •
edited
Loading

Mathlib CI status (docs):

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 20, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4224
c920177
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 20, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4224
353c83f
@leodemoura
Copy link
Member Author

Merging this one. @semorrison Reported that Mathlib issue is easy to fix.

@leodemoura leodemoura added this pull request to the merge queue May 20, 2024
Merged via the queue into master with commit b278f9d May 20, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semorrison semorrison Awaiting requested review from semorrison semorrison is a code owner

Assignees
No one assigned
Labels
breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stackoverflow when using cases on numeric expressions
3 participants
@leodemoura @leanprover-community-mathlib4-bot @semorrison