feat: define rotateLeft/Right with modulo #4229
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that rotateLeft/Right behave correctly even when the rotation amount is larger than the bitwidth.
This shall be followed up with
getLsb
theorems for rotations for LeanSAT.We choose to write
aux
definitions since it is cleaner to reason about theaux
theorems with the assumption thatrotation-amount < bit-width
, followed by auxiliary lemmas that link the behavior of rotation to the canonical case whenrotation-amount < bit-width
.Proof strategy we will execute based on these definitions: Link to proof of
getLsb_rotateLeft