Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: lake: fix noRelease test when lean repo is tagged #4244

Merged
merged 1 commit into from
May 21, 2024
Merged

chore: lake: fix noRelease test when lean repo is tagged #4244

merged 1 commit into from
May 21, 2024

Conversation

tydeu
Copy link
Member

@tydeu tydeu commented May 21, 2024

Fixes a bug with the Lake noRelease test where the test would fail if the current revision of the Lean repository itself had a tag.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label May 21, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 21, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4244
a7ff32e
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 21, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4244
60b13bd
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan full-ci labels May 21, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented May 21, 2024 •
edited
Loading

Mathlib CI status (docs):

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 21, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4244
427dd80
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 21, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4244
9bfd2d2
@semorrison semorrison added this pull request to the merge queue May 21, 2024
Merged via the queue into leanprover:master with commit 8ca0091 May 21, 2024
28 checks passed
@tydeu tydeu deleted the lake/noRelease-tag-fix branch May 22, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tydeu @leanprover-community-mathlib4-bot @semorrison