Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: case tactic in macros #4252

Merged
merged 1 commit into from
May 23, 2024
Merged

fix: case tactic in macros #4252

merged 1 commit into from
May 23, 2024

Conversation

leodemoura
Copy link
Member

We must erase macro scopes for tags in case as we do in cases .. with .. and induction .. with ...

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc May 22, 2024 21:27 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label May 22, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented May 22, 2024 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase f97a7d4234bd76bc0f61e43b8c6a78117c1376df --onto ff37e5d512efcd3981290270a2fc3ecb100bbd0c. (2024-05-22 21:37:16)
  • ❌ Mathlib branch lean-pr-testing-4252 built against this PR, but testing failed. (2024-05-22 23:04:57) View Log
  • ❌ Mathlib branch lean-pr-testing-4252 built against this PR, but testing failed. (2024-05-23 00:20:29) View Log

@leodemoura
fix: case tactic in macros
ed534b9 
We must erase macro scopes for tags in `case` as we do in `cases
.. with ..` and `induction .. with ..`.
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc May 22, 2024 22:04 Inactive
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 22, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4252
c553102
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 22, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4252
8b15d5a
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan full-ci labels May 22, 2024
@leodemoura
Copy link
Member Author

Merging since the Mathlib build succeeded, the failures happened during the test script.

@leodemoura leodemoura enabled auto-merge May 22, 2024 23:36
@leodemoura leodemoura added this pull request to the merge queue May 23, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 23, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4252
5b27a53
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 23, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4252
641ae78
Merged via the queue into master with commit 2bc41d8 May 23, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semorrison semorrison Awaiting requested review from semorrison semorrison is a code owner

Assignees
No one assigned
Labels
breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leodemoura @leanprover-community-mathlib4-bot