Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure incremental commands and tactics are reached only on supported paths #4259

Merged
merged 1 commit into from
May 23, 2024

Conversation

Kha
Copy link
Member

@Kha Kha commented May 23, 2024

Without this, it would not easy but perhaps be feasible to break incrementality when editing command prefixes such as set_option ... in theorem or also theorem namesp.name ... (which is a macro), especially if at some later point we support incrementality in input shifted by an edit. Explicit, sound support for these common cases will be brought back soon.

@Kha Kha requested a review from semorrison as a code owner May 23, 2024 17:40
@Kha Kha enabled auto-merge May 23, 2024 17:54
@Kha Kha added this pull request to the merge queue May 23, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label May 23, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 67338bac2333fa39a8656e8f90574784e4c23d3d --onto d984030c6a683a80313917b6fd3e77abdf497809. (2024-05-23 18:00:04)

Merged via the queue into leanprover:master with commit 811bad1 May 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants