Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: lake test improvements & lake lint #4261

Merged
merged 4 commits into from
May 24, 2024
Merged

feat: lake test improvements & lake lint #4261

merged 4 commits into from
May 24, 2024

Conversation

tydeu
Copy link
Member

@tydeu tydeu commented May 23, 2024 •
edited
Loading

Extends the functionality of lake test and adds a parallel command in lake lint.

  • Rename @[test_runner] / testRunner to @[test_driver] / testDriver. The old names are kept as deprecated aliases.
  • Extend help page for lake test and adds one for lake check-test.
  • Add lake lint and its parallel tag @[lint_driver] , setting lintDriver, and checker lake check-lint.
  • Add support for specifying test / lint drivers from dependencies.
  • Add testDriverArgs / lintDriverArgs for fixing additional arguments to the invocation of a driver script or executable.
  • Add support for library test drivers (but not library lint drivers).
  • lake check-test / lake check-lint only load the package (without dependencies), not the whole workspace.

Closes #4116. Closes #4121. Closes #4142.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label May 24, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 24, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4261
1d4bc5b
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 24, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4261
6199718
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 24, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4261
d643e5e
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 24, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4261
636ddc0
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan full-ci labels May 24, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

@tydeu tydeu added release-ci Enable all CI checks for a PR, like is done for releases and removed full-ci labels May 24, 2024
@tydeu tydeu marked this pull request as ready for review May 24, 2024 20:12
@tydeu tydeu added the will-merge-soon …unless someone speaks up label May 24, 2024
@tydeu tydeu added this pull request to the merge queue May 24, 2024
Merged via the queue into leanprover:master with commit 0448e3f May 24, 2024
31 checks passed
@tydeu tydeu deleted the lake/test+lint branch May 24, 2024 22:53
@austinletson austinletson mentioned this pull request May 27, 2024
Closed
@mattrobball mattrobball mentioned this pull request Aug 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan release-ci Enable all CI checks for a PR, like is done for releases toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN will-merge-soon …unless someone speaks up
Projects
None yet
Milestone
No milestone
2 participants
@tydeu @leanprover-community-mathlib4-bot