Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate shiftLeft_shiftLeft, shiftRight_shiftRight #4321

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

bollu
Copy link
Contributor

@bollu bollu commented Jun 2, 2024

As discussed previously (#4179 (comment)), we deprecate the two functions in favour of shift{Left, Right}_add.

As discussed previously (leanprover#4179 (comment)),
we deprecate the two functions in favour of `shift{Left, Right}_add`.
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 2, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Mathlib CI can not be attempted yet, as the nightly-testing-2024-06-02 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Mathlib CI should run now. (2024-06-02 17:27:40)

@bollu
Copy link
Contributor Author

bollu commented Jun 4, 2024

awaiting-review

@github-actions github-actions bot added the awaiting-review Waiting for someone to review the PR label Jun 4, 2024
@semorrison semorrison added this pull request to the merge queue Jun 4, 2024
Merged via the queue into leanprover:master with commit 9d46961 Jun 4, 2024
11 checks passed
Komyyy pushed a commit to Komyyy/lean4 that referenced this pull request Jun 4, 2024
…er#4321)

As discussed previously
(leanprover#4179 (comment)),
we deprecate the two functions in favour of `shift{Left, Right}_add`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review Waiting for someone to review the PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants