Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lake: track trace of cached build logs #4343

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

tydeu
Copy link
Member

@tydeu tydeu commented Jun 4, 2024

Stores the dependency trace for a build in the cached build log and then verifies that it matches the trace of the current build before replaying the log. Includes test.

Closes #4303.

@tydeu tydeu marked this pull request as ready for review June 4, 2024 17:28
@tydeu tydeu added the release-ci Enable all CI checks for a PR, like is done for releases label Jun 4, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 4, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jun 4, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jun 4, 2024
@tydeu tydeu changed the title fix: track trace of cached build logs fix: lake: track trace of cached build logs Jun 4, 2024
@tydeu tydeu added this pull request to the merge queue Jun 5, 2024
Merged via the queue into leanprover:master with commit ce67d6e Jun 5, 2024
27 checks passed
Copy link
Contributor

github-actions bot commented Jun 5, 2024

The backport to releases/v4.8.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-releases/v4.8.0 releases/v4.8.0
# Navigate to the new working tree
cd .worktrees/backport-releases/v4.8.0
# Create a new branch
git switch --create backport-4343-to-releases/v4.8.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ce67d6ef9ea598d5bc7b7dd84985342ca3559db9
# Push it to GitHub
git push --set-upstream origin backport-4343-to-releases/v4.8.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-releases/v4.8.0

Then, create a pull request where the base branch is releases/v4.8.0 and the compare/head branch is backport-4343-to-releases/v4.8.0.

tydeu added a commit to tydeu/lean4 that referenced this pull request Jun 5, 2024
Stores the dependency trace for a build in the cached build log and then
verifies that it matches the trace of the current build before replaying
the log. Includes test.

Closes leanprover#4303.
@tydeu tydeu deleted the lake/log-trace branch June 5, 2024 01:23
tydeu added a commit that referenced this pull request Jun 5, 2024
Stores the dependency trace for a build in the cached build log and then
verifies that it matches the trace of the current build before replaying
the log. Includes test.

Closes #4303.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport releases/v4.8.0 release-ci Enable all CI checks for a PR, like is done for releases toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

after introducing an error in a file and then reverting it, lake still reports the error
1 participant