Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upstream Char lemmas from Mathlib #4348

Merged
merged 1 commit into from
Jun 5, 2024
Merged

chore: upstream Char lemmas from Mathlib #4348

merged 1 commit into from
Jun 5, 2024

Conversation

semorrison
Copy link
Collaborator

The main purpose here is to add Char.ofUInt8, so I can delete the semantically suspect UInt8.toLower etc in Mathlib.

@semorrison semorrison enabled auto-merge June 4, 2024 23:29
@semorrison semorrison mentioned this pull request Jun 4, 2024
Closed
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc June 4, 2024 23:44 Inactive
@semorrison semorrison added this pull request to the merge queue Jun 4, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 4, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 612bdee68c1f68f3a171c0a86394964a933cb4e3 --onto 9d4696123693b2f0deee658b8021236e5168b4de. (2024-06-04 23:47:43)

Merged via the queue into master with commit 1d6fe34 Jun 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digama0 digama0 digama0 approved these changes

Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@semorrison @leanprover-community-mathlib4-bot @digama0