Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: split (for if-expressions) should work on non-propositional goals #4349

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

leodemoura
Copy link
Member

@leodemoura leodemoura commented Jun 4, 2024

Remark: when splitting an if-then-else term, the subgoals now have tags isTrue and isFalse instead of inl and inr.
closes #4313

@leodemoura leodemoura enabled auto-merge June 4, 2024 23:44
Co-authored-by: Mario Carneiro <[email protected]>
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc June 4, 2024 23:57 Inactive
@leodemoura leodemoura added this pull request to the merge queue Jun 5, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 5, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 28cf1cf5cfad0168d76d709a5e47fe4142a05fdc --onto 9d4696123693b2f0deee658b8021236e5168b4de. (2024-06-05 00:05:43)

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 5, 2024
`split` now generates the more meaningful `isTrue` and `isFalse` tag
@leodemoura
Copy link
Member Author

@semorrison The split on if-then-else-terms now creates subgoals with tags isTrue and isFalse. Reason: it is internally performing cases on a Decidable p instead of an Or p (Not p). In principle, we could rename the tags to inl and inr, but I think the new tags are more informative than the old ones: inl and inr. Some proofs will break, but the impact on Mathlib should be small since they have their own split_if tactic.

@leodemoura leodemoura enabled auto-merge June 5, 2024 04:31
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc June 5, 2024 04:42 Inactive
@leodemoura leodemoura added this pull request to the merge queue Jun 5, 2024
Merged via the queue into master with commit 46db59d Jun 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

split fails for non-propositional goals
3 participants