feat: lake: reliably cache logs and hashes #4402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jun 7, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jun 7, 2024
leanprover-community-mathlib4-bot
added
the
builds-mathlib
|
Mathlib CI status (docs):
|
tydeu
added
release-ci
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jun 12, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jun 12, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jun 12, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jun 12, 2024
|
!bench |
|
Here are the benchmark results for commit 079d6bc. |
digama0
added a commit
to digama0/leangz
that referenced
this pull request
Jun 13, 2024
semorrison
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jun 13, 2024
semorrison
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jun 13, 2024
|
Verified on |
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jun 13, 2024
The latest version of leantar [includes](digama0/leangz@v0.1.11...v0.1.12) the following features and bug fixes: * An improved `--help` output * Faster performance on windows and slow networks by reducing the number of OS calls (see digama0/leangz#3) * Support for a new trace file format due to land in leanprover/lean4#4402 (see [zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/ltar.20error.20aften.20lean.234402/near/444379353)) This is a backward compatible release, meaning that v0.1.12 can understand .ltar files produced by v0.1.11 and previous versions. So there should not be any hiccups during the transition period.
github-actions bot
pushed a commit
that referenced
this pull request
Jun 13, 2024
Moves the cached log into the trace file (no more `.log.json`). This means logs are no longer cached on fatal errors and this ensures that an out-of-date log is not associated with an up-to-date trace. Separately, `.hash` file generation was changed to be more reliable as well. `.hash` files are deleted as part of the build and always regenerate with `--rehash`. Closes #2751. (cherry picked from commit db74ee9)
semorrison
pushed a commit
that referenced
this pull request
Jun 14, 2024
Moves the cached log into the trace file (no more `.log.json`). This means logs are no longer cached on fatal errors and this ensures that an out-of-date log is not associated with an up-to-date trace. Separately, `.hash` file generation was changed to be more reliable as well. `.hash` files are deleted as part of the build and always regenerate with `--rehash`. Closes #2751. (cherry picked from commit db74ee9)
AntoineChambert-Loir
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jun 20, 2024
The latest version of leantar [includes](digama0/leangz@v0.1.11...v0.1.12) the following features and bug fixes: * An improved `--help` output * Faster performance on windows and slow networks by reducing the number of OS calls (see digama0/leangz#3) * Support for a new trace file format due to land in leanprover/lean4#4402 (see [zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/ltar.20error.20aften.20lean.234402/near/444379353)) This is a backward compatible release, meaning that v0.1.12 can understand .ltar files produced by v0.1.11 and previous versions. So there should not be any hiccups during the transition period.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the cached log into the trace file (no more
.log.json). This means logs are no longer cached on fatal errors and this ensures that an out-of-date log is not associated with an up-to-date trace. Separately,.hashfile generation was changed to be more reliable as well..hashfiles are deleted as part of the build and always regenerate with--rehash.Closes #2751.