fix: handle unimported builtin names for location links #4780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function `locationLinksFromDecl` could throw an error if the name it is provided doesn't exist in the environment, which is possible if for example an elaborator is a builtin. Closes leanprover#3789
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
mhuisi
approved these changes
Jul 18, 2024
leodemoura
requested review from
TwoFX,
digama0,
semorrison,
Vtec234,
Kha,
leodemoura and
tydeu
as code owners
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 27, 2024
The function `locationLinksFromDecl` could throw an error if the name it is provided doesn't exist in the environment, which is possible if for example an elaborator is a builtin. Closes #3789
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
locationLinksFromDeclcould throw an error if the name it is provided doesn't exist in the environment, which is possible if for example an elaborator is a builtin.Closes #3789