Populate OD of slave based on ESI file #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leducp
reviewed
May 2, 2024
leducp
reviewed
May 2, 2024
leducp
reviewed
May 2, 2024
leducp
reviewed
May 2, 2024
leducp
reviewed
May 2, 2024
leducp
reviewed
May 2, 2024
|
Nice work overall! |
Rdk-T
reviewed
May 3, 2024
nicolas71640
force-pushed
the
esi_to_od
branch
10 times, most recently
from
c9e7de3
to
c6c056b
Compare
leducp
approved these changes
May 6, 2024
nicolas71640
force-pushed
the
esi_to_od
branch
7 times, most recently
from
ec4dcaf
to
8fa74cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an od_generator tool that generate an od_populator.cc source file that populate the CoE::dictionary based on the object dictionnary embedded in the ESI file.
Limitation
I have handled only basic type of entry
Tests
To be tested on hardware