-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap 5 support #188
Comments
This was referenced Mar 30, 2023
guruofgentoo
added a commit
that referenced
this issue
May 19, 2023
- select bootstrap version via KEG_BOOTSTRAP_MAJOR_VERSION config (default 5) - select whether bootstrap is used at all via KEG_TEMPLATE_FLAVOR config (default bootstrap) - use tomselect for bootstrap 5+, in place of select2 (to remove jQuery dependency) refs #188
With the above commit, there are just a couple of BC-breaking updates to make in each app after updating kegelements and keg-auth:
|
guruofgentoo
added a commit
that referenced
this issue
May 22, 2023
- select bootstrap version via KEG_BOOTSTRAP_MAJOR_VERSION config (default 5) - select whether bootstrap is used at all via KEG_TEMPLATE_FLAVOR config (default bootstrap) - use tomselect for bootstrap 5+, in place of select2 (to remove jQuery dependency) refs #188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bootstrap 5 has been around for a couple years, so it's high time we support it. I do have this "done" at an app level in one project, but promoting to the lib level is going to be a little tricky. Some things to think through:
KEG_BOOTSTRAP_MAJOR_VERSION
config option, and switch on that when neededKEG_USE_SELECT2
styles
andscripts
blocksbody
and are named accordinglybody_scripts
and require apps to follow suitkeg_styles
andkeg_scripts
, and require apps to put those blocks in an appropriate place in the base templateKEG_TEMPLATE_FLAVOR
config option (defaults tobootstrap
)The text was updated successfully, but these errors were encountered: