Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow progress #246

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Slow progress #246

wants to merge 22 commits into from

Conversation

Nophinou
Copy link
Contributor

Moving on with the translation

Copy link

stackblitz bot commented Mar 10, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

vercel bot commented Mar 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
narrat-docs ❌ Failed (Inspect) May 10, 2024 4:58pm
narrat-editor-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 4:58pm

liana-p
liana-p previously approved these changes Mar 10, 2024
Copy link
Owner

@liana-p liana-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks 😄

@liana-p
Copy link
Owner

liana-p commented May 15, 2024

image
this still has incorrect paths, what you need to do is replace relative paths by absolute paths so that it can find the assets regardless of language. Otherwise it's looking in the same folder, but the french version of the docs has no assets there.

Rather than copying them, we just want to reference the same ones as the english docs using absolute paths.

For example in the french version of the getting started guide, the path to terminal.png is like this: /guides/terminal/terminal.png

So paths need to start with / and go to the folder where the original asset was. In this case it would be /guides/get-started/open-folder.png

There might be others to fix in your files though, basically replace relative asset paths with absolute ones

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants