-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incomplete ELF support #64
Comments
e_shstrndx
in ELF parser
Our string lookup logic is also questionable. See #190 (comment) |
TODO: NEEDS TEST! Our ELF support is incomplete. One issue we have is that we cannot handle more than 0xff00 section headers, because ELF special cases anything above this value. This change fixes this very shortcoming, by using the correct sequence of steps for inferring the number of section headers. Refs: libbpf#64 Signed-off-by: Daniel Müller <[email protected]>
Our ELF support is incomplete. One issue we have is that we cannot handle more than 0xff00 section headers, because ELF special cases anything above this value. This change fixes this very shortcoming, by using the correct sequence of steps for inferring the number of section headers. Refs: libbpf#64 Signed-off-by: Daniel Müller <[email protected]>
Our ELF support is incomplete. One issue we have is that we cannot handle more than 0xff00 section headers, because ELF special cases anything above this value. This change fixes this very shortcoming, by using the correct sequence of steps for inferring the number of section headers. Refs: libbpf#64 Signed-off-by: Daniel Müller <[email protected]>
Our ELF support is incomplete. One issue we have is that we cannot handle more than 0xff00 section headers, because ELF special cases anything above this value. This change fixes this very shortcoming, by using the correct sequence of steps for inferring the number of section headers. Refs: libbpf#64 Signed-off-by: Daniel Müller <[email protected]>
For reference, over in #384 (review) the following case was also mentioned:
|
Our ELF support is incomplete. One issue we have is that we cannot handle more than 0xff00 section headers, because ELF special cases anything above this value. This change fixes this very shortcoming, by using the correct sequence of steps for inferring the number of section headers. Refs: #64 Signed-off-by: Daniel Müller <[email protected]>
We should also check what happens when there are more than 0xffff sections and we try to access one via the |
Our ELF support is incomplete. One issue we have is that we cannot handle a e_shstrndx value greater than 0xff00, because ELF special cases anything above this value. This change fixes this very shortcoming, by using the correct sequence of steps for retrieving the actual value. Refs: libbpf#64 Signed-off-by: Daniel Müller <[email protected]>
Our ELF support is incomplete. One issue we have is that we cannot handle a e_shstrndx value greater than 0xff00, because ELF special cases anything above this value. This change fixes this very shortcoming, by using the correct sequence of steps for retrieving the actual value. Refs: #64 Signed-off-by: Daniel Müller <[email protected]>
Our ELF support is incomplete. One issue we have is that we cannot handle more than 0xffff program headers, because ELF special cases anything above this value. This change fixes this very shortcoming, by using the correct sequence of steps for retrieving the actual value. Refs: libbpf#64 Signed-off-by: Daniel Müller <[email protected]>
Our ELF support is incomplete. One issue we have is that we cannot handle more than 0xffff program headers, because ELF special cases anything above this value. This change fixes this very shortcoming, by using the correct sequence of steps for retrieving the actual value. Refs: libbpf#64 Signed-off-by: Daniel Müller <[email protected]>
Our ELF support is incomplete. One issue we have is that we cannot handle more than 0xffff program headers, because ELF special cases anything above this value. This change fixes this very shortcoming, by using the correct sequence of steps for retrieving the actual value. Refs: #64 Signed-off-by: Daniel Müller <[email protected]>
It appears as if the ELF parser does not handle all possible values of
e_shstrndx
correctly:https://github.com/libbpf/blazesym/blob/master/src/elf/parser.rs#L192-L207
ELF(5)
states:So we may have to special case
SHN_XINDEX
.The text was updated successfully, but these errors were encountered: