Add suport for unsorted normalization of addresses #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Müller <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #128 +/- ##
==========================================
- Coverage 69.71% 69.11% -0.61%
==========================================
Files 23 23
Lines 4346 4397 +51
==========================================
+ Hits 3030 3039 +9
- Misses 1316 1358 +42
☔ View full report in Codecov by Sentry. |
d-e-s-o
force-pushed
the
topic/normalize-unsorted
branch
2 times, most recently
from
e8c629c
to
820fef8
Compare
|
Rebased. |
d-e-s-o
force-pushed
the
topic/normalize-unsorted
branch
from
820fef8
to
71bf445
Compare
|
Please prioritize reviewing this logic over #129, as it will have to land first. |
d-e-s-o
force-pushed
the
topic/normalize-unsorted
branch
from
71bf445
to
2e04517
Compare
anakryiko
approved these changes
Apr 27, 2023
Introduce normalize_user_addrs_sorted_impl() as an implementation detail of normalize_user_addrs_sorted() that works on an iterator. We will later need this function to implement normalization of unsorted addresses. Signed-off-by: Daniel Müller <[email protected]>
This change introduces another normalization function variant that works on unsorted addresses. Signed-off-by: Daniel Müller <[email protected]>
d-e-s-o
force-pushed
the
topic/normalize-unsorted
branch
from
2e04517
to
56fd233
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see individual commits for descriptions.