Streamline APK ELF build ID retrieval #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-e-s-o
force-pushed
the
topic/opt-apk-elf-norm
branch
from
52b820d
to
94c879a
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #227 +/- ##
==========================================
+ Coverage 84.28% 84.82% +0.53%
==========================================
Files 26 26
Lines 3800 3783 -17
==========================================
+ Hits 3203 3209 +6
+ Misses 597 574 -23
☔ View full report in Codecov by Sentry. |
This change concludes the work for support APK ELF addresses by adding symbolization support, in addition to the previously covered normalization. Closes: libbpf#175 Signed-off-by: Daniel Müller <[email protected]>
d-e-s-o
force-pushed
the
topic/opt-apk-elf-norm
branch
from
94c879a
to
84003a1
Compare
|
Including the remaining pieces for APK ELF address symbolization now as well. |
d-e-s-o
force-pushed
the
topic/opt-apk-elf-norm
branch
2 times, most recently
from
696b5fc
to
e374fc6
Compare
This change optimizes the reading of build IDs from ELF files in APKs. Specifically, we stop re-mmapping the entire archive and searching for the ELF file in it by path and just work on the mmap we created initially. Signed-off-by: Daniel Müller <[email protected]>
Now that we have eliminated the re-mapping of APK archives for retrieval of the build ID of the contained ELF file, we no longer need the BuildIdReader::read_build_id_from_apk_elf method. Remove it. Signed-off-by: Daniel Müller <[email protected]>
We want APK ELF addresses to be normalized relative to the ELF file, as that allows for easy symbolization if the ELF file is available. The current code, however, report an address normalized to the containing APK. This change adjusts the logic and documents the property. We also start adding more doc tests. Signed-off-by: Daniel Müller <[email protected]>
d-e-s-o
force-pushed
the
topic/opt-apk-elf-norm
branch
from
e374fc6
to
9734c91
Compare
danielocfb
force-pushed
the
topic/opt-apk-elf-norm
branch
from
9734c91
to
305376a
Compare
danielocfb
force-pushed
the
topic/opt-apk-elf-norm
branch
from
305376a
to
64954a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see individual commits for descriptions.