Skip to content

Commit

Permalink
Remove support for "all" workarounds
Browse files Browse the repository at this point in the history
This should never be used. We may add new workarounds in the future,
and they should only be enabled explicitly when needed.
  • Loading branch information
Nikratio committed Jun 6, 2017
1 parent 5ed2cf8 commit 8999210
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
5 changes: 4 additions & 1 deletion ChangeLog
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,10 @@ Unreleased Changes
* Dropped support for the *nodelaysrv* workaround. The same effect
(enabling NODELAY on the server side *and* enabling X11 forwarding)
can be achieved by explicitly passing `-o ForwardX11`

* Removed support for `-o workaround=all`. Workarounds should always
enabled explicitly and only when needed. There is no point in always
enabling a potentially changing set of workarounds.

Release 2.9 (2017-04-17)
------------------------

Expand Down
5 changes: 0 additions & 5 deletions sshfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -422,10 +422,6 @@ static struct fuse_opt workaround_opts[] = {
SSHFS_OPT("none", truncate_workaround, 0),
SSHFS_OPT("none", buflimit_workaround, 0),
SSHFS_OPT("none", fstat_workaround, 0),
SSHFS_OPT("all", rename_workaround, 1),
SSHFS_OPT("all", truncate_workaround, 1),
SSHFS_OPT("all", buflimit_workaround, 1),
SSHFS_OPT("all", fstat_workaround, 1),
SSHFS_OPT("rename", rename_workaround, 1),
SSHFS_OPT("norename", rename_workaround, 0),
SSHFS_OPT("truncate", truncate_workaround, 1),
Expand Down Expand Up @@ -3318,7 +3314,6 @@ static void usage(const char *progname)
" cache if full (default: 5)\n"
" -o workaround=LIST colon separated list of workarounds\n"
" none no workarounds enabled\n"
" all all workarounds enabled\n"
" [no]rename fix renaming to existing file (default: off)\n"
" [no]truncate fix truncate for old servers (default: off)\n"
" [no]buflimit fix buffer fillup bug in server (default: on)\n"
Expand Down

0 comments on commit 8999210

Please sign in to comment.