Skip to content

Commit

Permalink
fix: mark all packages side-effect free (#2360)
Browse files Browse the repository at this point in the history
[Tree shaking](https://webpack.js.org/guides/tree-shaking/) results in
smaller web bundles by deleting unused code.

Our modules are side-effect free so mark them as such to signal to
bundlers that unused exports can be excluded from bundles.
  • Loading branch information
achingbrain committed Jan 16, 2024
1 parent 8bbd436 commit 3c96210
Show file tree
Hide file tree
Showing 34 changed files with 68 additions and 34 deletions.
3 changes: 2 additions & 1 deletion packages/connection-encrypter-plaintext/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -66,5 +66,6 @@
"aegir": "^42.0.0",
"protons": "^7.3.0",
"sinon": "^17.0.1"
}
},
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/crypto/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -106,5 +106,6 @@
"./dist/src/keys/rsa.js": "./dist/src/keys/rsa-browser.js",
"./dist/src/keys/secp256k1.js": "./dist/src/keys/secp256k1-browser.js",
"./dist/src/webcrypto.js": "./dist/src/webcrypto-browser.js"
}
},
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/interface-internal/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,5 +54,6 @@
},
"devDependencies": {
"aegir": "^42.0.0"
}
},
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/interface/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,5 +62,6 @@
},
"react-native": {
"./dist/src/events.js": "./dist/src/events.browser.js"
}
},
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/kad-dht/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -119,5 +119,6 @@
},
"browser": {
"./dist/src/routing-table/generated-prefix-list.js": "./dist/src/routing-table/generated-prefix-list-browser.js"
}
},
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/keychain/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,5 +72,6 @@
"@libp2p/peer-id-factory": "^4.0.4",
"aegir": "^42.0.0",
"datastore-core": "^9.1.1"
}
},
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/libp2p/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -138,5 +138,6 @@
"react-native": {
"./dist/src/connection-manager/constants.js": "./dist/src/connection-manager/constants.browser.js",
"./dist/src/config/connection-gater.js": "./dist/src/config/connection-gater.browser.js"
}
},
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/logger/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,5 +65,6 @@
"aegir": "^42.0.0",
"sinon": "^17.0.1",
"uint8arrays": "^5.0.0"
}
},
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/metrics-prometheus/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,5 +62,6 @@
"it-drain": "^3.0.5",
"it-pipe": "^3.0.1",
"p-defer": "^4.0.0"
}
},
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/multistream-select/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -76,5 +76,6 @@
"it-pair": "^2.0.6",
"it-pipe": "^3.0.1",
"p-timeout": "^6.0.0"
}
},
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/peer-collections/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,5 +62,6 @@
"aegir": "^42.0.0",
"sinon": "^17.0.1",
"sinon-ts": "^2.0.0"
}
},
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/peer-discovery-bootstrap/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,5 +63,6 @@
"@libp2p/logger": "^4.0.4",
"aegir": "^42.0.0",
"sinon-ts": "^2.0.0"
}
},
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/peer-discovery-mdns/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,5 +65,6 @@
"aegir": "^42.0.0",
"p-wait-for": "^5.0.2",
"sinon-ts": "^2.0.0"
}
},
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/peer-id-factory/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,5 +68,6 @@
"aegir": "^42.0.0",
"multiformats": "^13.0.0",
"protons": "^7.3.0"
}
},
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/peer-id/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,5 +59,6 @@
},
"devDependencies": {
"aegir": "^42.0.0"
}
},
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/peer-record/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -74,5 +74,6 @@
"@libp2p/peer-id-factory": "^4.0.4",
"aegir": "^42.0.0",
"protons": "^7.3.0"
}
},
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/peer-store/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -82,5 +82,6 @@
"p-event": "^6.0.0",
"protons": "^7.3.0",
"sinon": "^17.0.1"
}
},
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/pnet/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,5 +68,6 @@
"@types/xsalsa20": "^1.1.0",
"aegir": "^42.0.0",
"it-all": "^3.0.3"
}
},
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/protocol-autonat/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -73,5 +73,6 @@
"protons": "^7.3.0",
"sinon": "^17.0.1",
"sinon-ts": "^2.0.0"
}
},
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/protocol-dcutr/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -66,5 +66,6 @@
"protons": "^7.3.0",
"sinon": "^17.0.1",
"sinon-ts": "^2.0.0"
}
},
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/protocol-fetch/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -66,5 +66,6 @@
"protons": "^7.3.0",
"sinon": "^17.0.1",
"sinon-ts": "^2.0.0"
}
},
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/protocol-identify/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -75,5 +75,6 @@
"protons": "^7.3.0",
"sinon": "^17.0.1",
"sinon-ts": "^2.0.0"
}
},
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/protocol-perf/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,5 +64,6 @@
"it-last": "^3.0.3",
"it-pair": "^2.0.6",
"sinon-ts": "^2.0.0"
}
},
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/protocol-ping/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,5 +65,6 @@
"it-pair": "^2.0.6",
"p-defer": "^4.0.0",
"sinon-ts": "^2.0.0"
}
},
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/pubsub-floodsub/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -77,5 +77,6 @@
"p-wait-for": "^5.0.2",
"protons": "^7.3.0",
"sinon": "^17.0.1"
}
},
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/pubsub/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -109,5 +109,6 @@
"protons": "^7.3.0",
"protons-runtime": "^5.0.0",
"sinon": "^17.0.1"
}
},
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/stream-multiplexer-mplex/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -85,5 +85,6 @@
"it-pair": "^2.0.6",
"p-defer": "^4.0.0",
"random-int": "^3.0.0"
}
},
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/transport-circuit-relay-v2/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -84,5 +84,6 @@
"race-signal": "^1.0.2",
"sinon": "^17.0.1",
"sinon-ts": "^2.0.0"
}
},
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/transport-tcp/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,5 +71,6 @@
"p-defer": "^4.0.0",
"sinon": "^17.0.1",
"uint8arrays": "^5.0.0"
}
},
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/transport-webrtc/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -101,5 +101,6 @@
},
"react-native": {
"./dist/src/webrtc/index.js": "./dist/src/webrtc/index.react-native.js"
}
},
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/transport-websockets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -100,5 +100,6 @@
},
"browser": {
"./dist/src/listener.js": "./dist/src/listener.browser.js"
}
},
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/transport-webtransport/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,5 +71,6 @@
},
"react-native": {
"./dist/src/listener.js": "./dist/src/listener.browser.js"
}
},
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/upnp-nat/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,5 +62,6 @@
"@libp2p/peer-id-factory": "^4.0.4",
"aegir": "^42.0.0",
"sinon-ts": "^2.0.0"
}
},
"sideEffects": false
}
3 changes: 2 additions & 1 deletion packages/utils/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -149,5 +149,6 @@
"sinon": "^17.0.1",
"sinon-ts": "^2.0.0",
"uint8arrays": "^5.0.0"
}
},
"sideEffects": false
}

0 comments on commit 3c96210

Please sign in to comment.