Skip to content

Commit

Permalink
refactor(libp2p): remove unnecessary any-signal (#1988)
Browse files Browse the repository at this point in the history
Removes use of `any-signal` where we only have one signal.
  • Loading branch information
achingbrain committed Aug 25, 2023
1 parent 098ba08 commit 6a02d76
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
5 changes: 1 addition & 4 deletions packages/libp2p/src/autonat/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import { peerIdFromBytes } from '@libp2p/peer-id'
import { createEd25519PeerId } from '@libp2p/peer-id-factory'
import { multiaddr, protocols } from '@multiformats/multiaddr'
import { abortableDuplex } from 'abortable-iterator'
import { anySignal } from 'any-signal'
import first from 'it-first'
import * as lp from 'it-length-prefixed'
import map from 'it-map'
Expand Down Expand Up @@ -154,7 +153,7 @@ class DefaultAutoNATService implements Startable {
* Handle an incoming AutoNAT request
*/
async handleIncomingAutonatStream (data: IncomingStreamData): Promise<void> {
const signal = anySignal([AbortSignal.timeout(this.timeout)])
const signal = AbortSignal.timeout(this.timeout)

// this controller may be used while dialing lots of peers so prevent MaxListenersExceededWarning
// appearing in the console
Expand Down Expand Up @@ -386,8 +385,6 @@ class DefaultAutoNATService implements Startable {
)
} catch (err) {
log.error('error handling incoming autonat stream', err)
} finally {
signal.clear()
}
}

Expand Down
4 changes: 1 addition & 3 deletions packages/libp2p/src/upgrader.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { logger } from '@libp2p/logger'
import * as mss from '@libp2p/multistream-select'
import { peerIdFromString } from '@libp2p/peer-id'
import { abortableDuplex } from 'abortable-iterator'
import { anySignal } from 'any-signal'
import { createConnection } from './connection/index.js'
import { INBOUND_UPGRADE_TIMEOUT } from './connection-manager/constants.js'
import { codes } from './errors.js'
Expand Down Expand Up @@ -164,7 +163,7 @@ export class DefaultUpgrader implements Upgrader {
let muxerFactory: StreamMuxerFactory | undefined
let cryptoProtocol

const signal = anySignal([AbortSignal.timeout(this.inboundUpgradeTimeout)])
const signal = AbortSignal.timeout(this.inboundUpgradeTimeout)

try {
// fails on node < 15.4
Expand Down Expand Up @@ -257,7 +256,6 @@ export class DefaultUpgrader implements Upgrader {
})
} finally {
this.components.connectionManager.afterUpgradeInbound()
signal.clear()
}
}

Expand Down

0 comments on commit 6a02d76

Please sign in to comment.