Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot change mode if drag disabled #147

Closed
emulienfou opened this issue Aug 26, 2020 · 2 comments
Closed

Cannot change mode if drag disabled #147

emulienfou opened this issue Aug 26, 2020 · 2 comments
Labels
bug ready release

Comments

@emulienfou
Copy link
Contributor

Version

Latest: 4.17.1

Description

If you disable option drag, you cannot switch from mini to full mode.

Steps to Reproduce

  1. Go to demo site: https://react-jinke-music-player.netlify.app/
  2. Un-check option drag
  3. Click to mini player to switch to full, nothing append

Expected behavior

Switch from mini to full mode even if drag option is disabled
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.96. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the bug label Aug 26, 2020
lijinke666 added a commit that referenced this issue Aug 27, 2020
@lijinke666
fix: cannot toggle mode if drag disabled #147
ca5c5ff
@lijinke666
Copy link
Owner

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug ready release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emulienfou @lijinke666