Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Fade-in / fade-out on pause and play #238

Closed
JeffreyCA opened this issue Dec 24, 2020 · 4 comments
Closed

Feature Request: Fade-in / fade-out on pause and play #238

JeffreyCA opened this issue Dec 24, 2020 · 4 comments

Comments

@JeffreyCA
Copy link
Contributor

Description

I would like to see a feature similar to Spotify where if you press play or pause, the music fades out instead of stopping/starting abruptly.

Expect Api Name

fadeIn: number (in seconds)
fadeOut: number (in seconds)

@github-actions
Copy link

github-actions bot commented Jan 5, 2021

Hello @JeffreyCA, Your suggestion is very good. If I have time, I will consider developing this function. Of course, you are also welcome to propose PR.
你好 @JeffreyCA,你的这个建议非常好, 如果有空的话, 我会考虑开发这个功能, 当然, 也欢迎你提PR。

@github-actions
Copy link

github-actions bot commented Jan 5, 2021

Hello @JeffreyCA, This bug has been fixed and will be released together with the next release.
你好 @JeffreyCA,这个bug已经修复, 会在下个版本一起发布。

@github-actions github-actions bot removed the Progress label Jan 5, 2021
@github-actions github-actions bot closed this as completed Jan 5, 2021
@JeffreyCA
Copy link
Contributor Author

Thank you! One small thing: with the fade-out, it turns into "Pause" when the audio is completely faded. Can you make the "Play" button turn into "Pause" immediately after clicking it?

@JeffreyCA
Copy link
Contributor Author

Also, I noticed if you pause playback, then drag the seekbar, the play button becomes "pause", even though no audio is playing.

This happens with the demo: https://www.lijinke.cn/react-music-player/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants