Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini player throws error if showDestroy is false #91

Closed
deluan opened this issue Mar 4, 2020 · 2 comments
Closed

Mini player throws error if showDestroy is false #91

deluan opened this issue Mar 4, 2020 · 2 comments
Labels

Comments

@deluan
Copy link

deluan commented Mar 4, 2020

Version

4.10.0

Description

When I have a MiniPlayer and the showDestroy option is false, if I click on the MiniPlayer, if throws an exception in the console.

Steps to Reproduce

  1. Go to the demo page (http://www.lijinke.cn/react-music-player/)
  2. Disable showDestroy option
  3. Click on the MiniPlayer

Expected Behavior

The MiniPlayer turns into the full player version (as when the showDestroy option is true)

Current Behavior

An exception is thrown in the console

Uncaught TypeError: Cannot read property 'contains' of null
    at Object.value [as onStop] (main.b767a6fe.js:27)
    at Object.n.onDragStop [as onStop] (main.b767a6fe.js:33)
    at HTMLDocument.o.handleDragStop (main.b767a6fe.js:33)

System information

MacOS 10.14.6
Browsers tested:

  • Chrome 80.0.3987.122 (Official Build) (64-bit)
  • Firefox 73.0.1 (64-bit)

Comments

Thanks for all the hard work to make this awesome player

@lijinke666
Copy link
Owner

Fixed! thank your feedback. there is another bug and other fixes to be released together

@lijinke666
Copy link
Owner

fixed. please try use 4.10.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants