Skip to content

Commit

Permalink
fix: fix invalid backend urls
Browse files Browse the repository at this point in the history
  • Loading branch information
linderttobias committed Feb 18, 2024
1 parent 1d61462 commit cfa1ea9
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/frontend-development.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ jobs:
application: frontend
environment: development
runner: ubuntu-latest
backend-url: https://gcloudmaps-backend-development-osv4zrdlyq-ew.a.run.app

secrets:
WIF_PROVIDER: ${{ secrets.WIF_PROVIDER }}
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/frontend-production.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ jobs:
application: frontend
environment: production
runner: ubuntu-latest
backend-url: api.gcloudmaps.com

secrets:
WIF_PROVIDER: ${{ secrets.WIF_PROVIDER }}
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/template-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ on:
environment:
required: true
type: string #Its either production or development
backend-url:
type: string
secrets:
# Workload Identity Federation Provider
WIF_PROVIDER:
Expand Down Expand Up @@ -50,6 +52,7 @@ jobs:
push: true
tags: europe-west1-docker.pkg.dev/gcloudmaps/gcloudmaps/${{ inputs.application }}-${{ inputs.environment }}:${{ github.sha }}
context: application/${{ inputs.application }}
build-args: REACT_APP_API_URL=${{ inputs.backend-url }}

- name: Build and push Docker image - No Tags
uses: docker/build-push-action@v5
Expand All @@ -58,6 +61,7 @@ jobs:
tags: europe-west1-docker.pkg.dev/gcloudmaps/gcloudmaps/${{ inputs.application }}-${{ inputs.environment }}
context: application/${{ inputs.application }}


deploy-to-cloudrun:
permissions:
contents: 'read' # Required to Checkout Repo
Expand Down

0 comments on commit cfa1ea9

Please sign in to comment.